Show eslint warnings/errors in vscode?

Plugin version

5.0.3

ESLint version

8.6.0

Node.js version

16.13.2

npm/yarn version

yarn 1.22.17

Operating system

macOS Monterey 12.2.1

Bug description

I have this plugin installed and configured. I would expect to see warnings in my test files in vscode, but don’t. I do see them when I run them on the command line.

Steps to reproduce

install https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint into vscode.

set up a basic eslint config, and write a test. I am able to see the errors when run in the command line, but not in vscode.

Error output/screenshots

No response

ESLint configuration

const fs = require('fs');
const path = require('path');

const schemaString = fs.readFileSync(
  path.resolve(__dirname, '../server/dist/schema.graphqls'),
  'utf8'
);

module.exports = {
  extends: ['@tock'],
  root: true,
  plugins: ['testing-library', 'jest-dom'],
  rules: {
    'graphql/template-strings': ['error', { env: 'apollo', schemaString }],
    'jsx-a11y/no-static-element-interactions': 'off',
    'jsx-a11y/tabindex-no-positive': 'off',
    'jsx-a11y/no-autofocus': 'off',
    'jsx-a11y/label-has-associated-control': 'off',
    'jsx-a11y/anchor-is-valid': 'off',
    'no-restricted-imports': [
      'warn',
      {
        paths: [
          {
            name: '@material-ui/core',
            importNames: [
              'Button',
              'Dialog',
              'DialogActions',
              'DialogContent',
              'DialogTitle',
              'Divider',
              'Drawer',
              'Grid',
              'Tooltip',
              'Typography',
              'makeStyles',
              'Theme',
              'createStyles',
              'WithStyles',
              'withStyles',
            ],
            message:
              "Please import from from 'ui' instead. For styles and theme related imports, import from from '@material-ui/core/styles' instead.",
          },
          {
            // These are fine to import in a local branch, but not meant to be merged into master.
            name: 'shared/utils/devUtils',
          },
        ],
      },
    ],
  },
  overrides: [
    {
      files: ['**/__tests__/**/*.[jt]s?(x)', '**/?(*.)+(spec|test).[jt]s?(x)'],
      extends: ['plugin:testing-library/react', 'plugin:jest-dom/recommended'],
      rules: {
        'testing-library/no-node-access': 'off',
      },
    },
  ],
};

Rule(s) affected

all are affected in vscode but not in command line.

Anything else?

here’s the command that will show errors/warnings for tests:

npx eslint --cache --cache-location ./.eslint-cache -c .eslintrc.js --no-eslintrc --max-warnings 0 'src/*/js/**/*.{ts,tsx}' '../shared/src/js/**/*.{ts,tsx}' 'test/client/js/**/*.{ts,tsx}'

Do you want to submit a pull request to fix this bug?

No

[kelly-tock]

yeah, I have what I consider a workaround. my guess is the plugin is taking only the one in that directory that it finds.

[Belco90]

Yeah, I understand your use case. Just wanted to see if we could spot something else by extending the plugin outside the overrides section.

Oh, I see. If you have another ESLint config file that can take more priority than the overrides property from the main config file (I don’t remember the exact order for this right now). You need to stick to just one of those 2 ways then: or enabling eslint-plugin-testing-library in the overrides of the main one and removing the test config one, or remove eslint-plugin-testing-library from the main config file and enable it in the test config file.

Is it 100% solved then?