Include typings folder in npm publish.
See original GitHub issueThanks for a helpful lib! It appears that the typings folder is not actually making it to npm
, so the TS support isn’t working. You can see that the typings
folder isn’t there by checking it out on runpkg
: https://runpkg.com/?@testing-library/user-event@4.1.0/dist/index.js. Compare this to say, @testing-library/react
, whose typings
folder is published to npm
: https://runpkg.com/?@testing-library/react@8.0.5/dist/index.js. Since there’s no .npmignore
nor a files
field in the package.json
, I believe everything that’s on GitHub is ending up published to npm
(which is strange that typings
wouldn’t also make it in this case), which even means your tests and source are getting bundled in folks’ node_modules
😬 Finally, it appears the package.json
version is out of lockstep with the npm
published version. Happy to make a PR to help with these things if you like! Thanks again for a helpful lib.
Issue Analytics
- State:
- Created 4 years ago
- Reactions:1
- Comments:8 (6 by maintainers)
Top GitHub Comments
@Gpx I think this issue can be closed. The typings folder is being published to npm: https://unpkg.com/browse/@testing-library/user-event@4.2.0/typings/index.d.ts
@parkerziegler you were looking at 4.1.0 which was before the typings were added to this repo. The typings were published in 4.2.0: https://github.com/testing-library/user-event/pull/134
Let’s see how the discussion on https://github.com/testing-library/react-testing-library/pull/437 goes