[BUG] time remaining estimate doesn't work on slow tasks

Describe the bug

the TimeRemainingColumn() never shows an estimate if the task is slower than speed_estimate_period (default 30 seconds)

code to reproduce:

import time
import rich.progress

p = rich.progress.Progress(
	*rich.progress.Progress.get_default_columns(),
	rich.progress.TimeElapsedColumn()
)

task = p.add_task(description='test')

with p:
	for i in p.track(range(20), task_id=task):
		time.sleep(60)

this happens because of this code: https://github.com/Textualize/rich/blob/1772458f80924c78fa3a8d0260bca9762ad86e18/rich/progress.py#L1441-L1446

the progresssamples older than speed_estimate_period are removed from the queue before a speed estimate can be calculated.

I’m using rich-12.4.1 on linux.

[0phoff]

Sorry for commenting on this closed issue, but would it be an option to allow speed_estimate_period to be set to None or -1 to disable this filter ? I quickly looked through the code and it seems pretty trivial to add. I am willing to implement it and send a PR, but wanted to know if @willmcgugan likes the idea or not.

The reason for adding this is that we sometimes have very consistent processes (eg. a Deep Learning training epoch) that still take hours to complete. In these scenarios it is nice to have an estimate finishing time, even if it is not super accurate (most DL users know to take these estimates with a grain of salt, but it is still nice to have them!). As the time per epoch varies drastically depending on dataset size, model choice, and compute platform, it is virtually impossible to find a good value for speed_estimate_period. I could set it to a ridicule number, but IMO it is nicer if the API allows you to set it to None to disable it.

The default value would still be unchanged (30sec), but this allows “more advanced” users to get around it. Since multiple columns depend on this Speed computation, it is easier to add it as an option to Rich, rather than having a user reimplement (TimeRemainingColumn, SpeedColumn, etc) to work around it.

[github-actions[bot]]

Did I solve your problem?

Why not buy the devs a coffee to say thanks?