reuse of the name 'box' seems to cause an issue in examples/table_movie.py

https://github.com/willmcgugan/rich/blob/23aa71774457c34fe6d1fb527c1c2972447bb18d/examples/table_movie.py#L166

change box on L166 & L173 to abox or similar.

[cariaso]

I confirm that when run exactly as is, it runs fine. However I had cannibalized it and nested it in a way that triggered a crash due to the reassignment of the box name. I assumed it affected the original and tried to leave a comment in github on the line, which then led me to “Reference in new issue” and now here we are.

Since examples are likely to be reused in funny ways by novices, I do see some value in making it a bit less likely to surprise someone else.

and by the time I submit this comment, I see the relevant pull request from aidaco has already beem merged. Closing this issue, thanks to all for amazing speed on a truly minor issue.

On Sun, Sep 19, 2021 at 8:38 AM Will McGugan @.***> wrote:

That’s what I figured. It’s obviously not correct, but doesn’t break anything. Anyone want to submit a PR?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/willmcgugan/rich/issues/1503#issuecomment-922467302, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA6TEUE44ERLDWQBBEZLCLUCXKSTANCNFSM5EJ7NYKQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

–

Mike Cariaso http://www.cariaso.com

[github-actions[bot]]

Did I solve your problem?

Consider sponsoring the ongoing work on Rich and Textual.

Or buy me a coffee to say thanks.

– Will McGugan