Button variant="disabled" gives type hinting error

Here’s a sample program to reproduce the issue:

from textual.app import App, ComposeResult
from textual.widgets import Button

class MinimalApp(App):

    def compose(self) -> ComposeResult:
        yield Button(variant="disabled")

if __name__ == "__main__":
    app = MinimalApp()
    app.run()

Here’s the error I get:

$ mypy minimal.py 
minimal.py:7: error: Argument "variant" to "Button" has incompatible type "Literal['disabled']"; expected "Literal['default', 'primary', 'success', 'warning', 'error']"  [arg-type]
Found 1 error in 1 file (checked 1 source file)

Looking through https://github.com/Textualize/textual/blob/main/src/textual/widgets/_button.py, seems like the disabled variant is missing here:

ButtonVariant = Literal["default", "primary", "success", "warning", "error"]
_VALID_BUTTON_VARIANTS = {"default", "primary", "success", "warning", "error"}

[davep]

Just to update: as from the next release this will raise an exception at runtime.

[learnbyexample]

Thanks for the explanation and the sample code (in which I also learned that CSS can be assigned in the code itself).

I’ll close this issue as my code now correctly uses disabled=True, thanks 😃