Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

🐞 App crash after reopening BottomSheet modal 😱🥺

See original GitHub issue

Hey there, amazing 49ers! 🤠👋

I hope you’re having a fantastic day! 😃 I’ve stumbled upon a 🐛 that’s causing our app to crash, and I could really use your expertise to squash it. 🙏

Steps to reproduce the issue 🕵️‍♀️:

Create a button that, when clicked, opens the BottomSheet modal with the following code:

var page = new DataPickerBottomSheetPage();
page.IsModal = true;
page.ShowHandle = true;
page.Cancelable = true;
page.Show(Window);

Click on the button 🖱️ and behold the modal in all its glory! 🌟
Dismiss the BottomSheet modal by pulling it down like a fancy window blind 📉
Click on the same button again to reopen the modal 🔄 💥 Boom! The app goes down like a house of cards 🃏🏠

Expected behavior 🧐:

The app should allow us to open and close the BottomSheet modal as many times as our hearts desire, without any crashes. 😍🔄

Actual behavior 😵:

The app crashes when we try to reopen the BottomSheet modal after dismissing it. 😢💔

Environment 🌍:

Specification	Details
Device Model	Android Emulator - Pixel 5
Operating System	Android 13
BottomSheet Version	1.0.0-alpha4

I know you folks are wizards when it comes to fixing bugs like these! 🧙‍♂️ So, I’m sure this issue will be resolved in no time. Thanks in advance for your help! You’re the best! 😎🎉

Keep up the fantastic work, and may the force be with you! 🚀🌟

Issue Analytics

State:
Created 6 months ago
Comments:8 (5 by maintainers)

Top GitHub Comments

1reaction

paulvarachecommented, Apr 25, 2023

Hi,

1.0.0-alpha6 was just published and it removes the need to use DetentsCollection. It also fixes this issue

1reaction

paulvarachecommented, Apr 5, 2023

I have isolated the issue and will try to get a fix for it. In the meantime, a workaround is to use the DetentsCollection:

Replace

    <the49:BottomSheet.Detents>
        <the49:FullscreenDetent />
    </the49:BottomSheet.Detents>

With

<the49:BottomSheet.Detents>
        <the49:DetentsCollection>
            <the49:FullscreenDetent />
        </the49:DetentsCollection>
    </the49:BottomSheet.Detents>

And the problem goes away. Alternatively setting the Detents programmatically in the Code-Behind will also fix this issue