question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Auto-detected URLs shouldn't assume https

See original GitHub issue
  • Node version: v9.11.1
  • Browser version: chrome latest
  • Device, operating system: windows 10
  • The Lounge version: source@de1e609

URLs without a scheme are now detected by linkify-it.js since #2397 was merged.

It’s the server’s responsibility to redirect from http->https, not the client’s. This breaks many sites that do not have SSL certs where I would expect a link in thelounge would work, but instead results in a nasty ERR_CERT_AUTHORITY_INVALID error in the browser.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:1
  • Comments:10 (10 by maintainers)

github_iconTop GitHub Comments

2reactions
xPawcommented, Jun 8, 2018

I have already stated my reasons in favour of http in the PR. TL;DR: Defaulting https creates a negative user experience and is not related to security.

I also haven’t seen any other service defaulting to https.

@McInkay what’s your take?

1reaction
dgwcommented, Jun 9, 2018

Even I think this is too trivial for a setting, and I ♥ checkboxes… 😝

Read more comments on GitHub >

github_iconTop Results From Across the Web

Don't use protocol-relative URLs for external links #406 - GitHub
Assume someone posts a link like this: www.some.domain Lounge's URL parser will make ... Auto-detected URLs shouldn't assume https #2525.
Read more >
Ability to force using a scheme instead of scheme-relative URLs
I've created https://www.drupal.org/project/metatag/issues/2925974. I think this is the right way to go - The CDN module does well in having ...
Read more >
Why do browsers default to http: and not https: for typed in ...
What I see seems to assume http will remain default practically forever: Chrome's move to hiding http:// in URL bar is a step...
Read more >
Is redirecting http to https a bad idea? - Stack Overflow
I don't think redirecting from HTTP to HTTPS is necessarily harmful, but this should be done carfully. What's important is that you shouldn't...
Read more >
urllib.request — Extensible library for opening URLs — Python ...
For HTTP and HTTPS URLs, this function returns a http.client.HTTPResponse object slightly ... To disable autodetected proxy pass an empty dictionary.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found