Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Noscript addon breaks image previewer if videos are linked

See original GitHub issue

Node version: v14.18.1
Browser version: FF v101.0
Device, operating system: W10
The Lounge version: v4.3.1

When people post images in the chat, usually you can click on them and an overlay div is opening showing the image in full size over the whole visible area of the window. I guess since the last update of v4.3.1 it is showing the image overlay only in the narrow left channel-list area instead of the whole chat area.

Now for the cause of the issue: it seems TheLounge is now trying to load external resources to make this work like it should. I have noscript-addon installed and it blocks j-chaos.net, see: loung

when I temporarily allow j-chaos.net with noscript, TheLounge opens the images as expected. So it seems TheLounge is dependent on ressources of j-chaos.net to work properly. This should not be the case. Opening images in the Chat should not require the loading of external js(?) ressources to work.

please consider reworking this functionality without depending on external resources (if that really is the case).

Issue Analytics

State:
Created a year ago
Comments:6 (3 by maintainers)

Top GitHub Comments

2reactions

xPawcommented, Jun 4, 2022

noscript may also block media elements, not just actual scripts.
Lounge has script-src self which would prevent any third party scripts from loading if there was such an issue.
With previews enabled, TL will indeed embed video/audio elements from links.

https://github.com/thelounge/thelounge/blob/d4cc2dd361bd2f166924dd18efdc57634d67bc19/src/server.js#L304

Sounds to me like noscript is hiding/breaking some element which causes html to shift. I just installed noscript and tried it on my site (steamdb.info) and it’s causing all kinds of issues around a video element:

So this doesn’t sound like a bug with TL.

0reactions

tokariucommented, Jun 4, 2022

Out of interest though… Looking at https://somecast.j-chaos.net:8989/streamname implies a stream, not an image. So which one is it now? Did it return an image content type or a video embbed?

the URL was posted in the chat. TheLounge did NOT do any preview of that URL (it was an icecast music stream afaik). maybe it tried to produce a preview of said URL but failed to do so (even if there is nothing to show). Never had an issue like that with TL before and it is only happening with this kind of URL.

Top Results From Across the Web

Noscript interaction with embedded videos : r/firefox - Reddit

I have following problem: NoScript completely blocks all embedded videos. Whitelisted Included. Can't play them, there is only black rectangle in place of...

Changelog - NoScript: block scripts and own your browser!

The NoScript Security Suite is a free extensions for Firefox, Chrome and other browsers, preemptively blocks malicious scripts and allows JavaScript and ...

NoScript Security Suite – Get this Extension for Firefox (en-US)

Download NoScript Security Suite for Firefox. The best security you can get in a web browser! Allow potentially malicious web content to run ......

NoScript breaking Chromium Browsers | MalwareTips Forums

I believe the latest update broke NoScript in Chrome. My Chrome is fully updated. As of today, NoScript has completely broke Chrome.

How to use NoScript efficiently - gHacks Tech News

NoScript is a very powerful script blocker add-on for the Firefox web browser that blocks any script from running automatically in the browser....