question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`/quit` behaves differently from `/disconnect`

See original GitHub issue
  • Node version: v12.18.3
  • Browser version: Chrome 89.0.4389.114
  • Device, operating system: Debian bullseye
  • The Lounge version: v4.2.0

This may be a different bug depending on what the intent is.

  1. The documentation for /quit and /disconnect are the same. But not identical.
/disconnect [message]	
Disconnect from the current network with an optionally-provided message.
/quit [message]	
Disconnect from the current network with an optional message.
  1. /quit will delete the server instead of just disconnecting (and leaving the server on the server list).

If the documentation is canon, then /quit should just be merged with /disconnect as the same command and the documentation should be made to read the same.

If the code is canon, then the documentation needs to be updated. Though I’d be curious to know why, since most clients will treat /quit and /disconnect the same.


Other notes:

Looks like /disconnect was forked off as a separate command here: https://github.com/thelounge/thelounge/commit/047a79ead6b804d5b85bd91b5aada5c3ea3686d1 But /quit has some extra code to delete the network here (which has apparently been there for years): https://github.com/thelounge/thelounge/blob/8dd9bc0e9813af29fd1a42a33f19c7ffea820e26/src/plugins/inputs/quit.js#L12

Issue Analytics

  • State:open
  • Created 2 years ago
  • Comments:7 (4 by maintainers)

github_iconTop GitHub Comments

7reactions
nikitalitacommented, Apr 15, 2021

I’ve been bitten by this; I wouldn’t be so irritated about it if it didn’t lose my entire server settings and all the chatrooms I was in with no way to recover them. I had to recover my password and re-set up my auth certificate as well. I don’t think it’s really advisable to let users just say /quit without a confirmation or a prompt.

2reactions
dgwcommented, Apr 6, 2021

/quit in other clients means the client terminates.
This isn’t an applicable thing to do for TL so you can’t translate your experience from say weechat or irssi over.

Love this assumption. I was talking about Colloquy, KVIrc, Textual, and other GUI clients with multi-network capability.

Whatever, as long as we arrive at sensible behavior and/or docs.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How do I make the program exit when server is disconnected ...
I have created a server and client communication system in C and when the server is shutdown or quit, the client goes into...
Read more >
Disconnectedclient disconnected from CONNECTED state ...
The 'disconnected from CONNECTED' means that the browser socket was connected at one time in the past then disconnected. The tests either ran...
Read more >
8 Things Leaders Do That Make Employees Quit
Some common leadership mistakes that drive employees to quit are: ... But if there is a disconnect by the time that candidate becomes...
Read more >
Solved: netcat (nc) doesn't terminate at end of transmission
If it did quit, it returns a FIN packet, closing the connection altogether. So we have two “may or may not”, leading to...
Read more >
Dissociation and depersonalization: Causes, risk factors, and ...
Dissociative identity disorder : A person becomes confused about who they are and feel like a stranger to themselves. They may behave differently...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found