`/quit` behaves differently from `/disconnect`
See original GitHub issue- Node version: v12.18.3
- Browser version: Chrome 89.0.4389.114
- Device, operating system: Debian bullseye
- The Lounge version: v4.2.0
This may be a different bug depending on what the intent is.
- The documentation for
/quit
and/disconnect
are the same. But not identical.
/disconnect [message]
Disconnect from the current network with an optionally-provided message.
/quit [message]
Disconnect from the current network with an optional message.
/quit
will delete the server instead of just disconnecting (and leaving the server on the server list).
If the documentation is canon, then /quit
should just be merged with /disconnect
as the same command and the documentation should be made to read the same.
If the code is canon, then the documentation needs to be updated. Though I’d be curious to know why, since most clients will treat /quit
and /disconnect
the same.
Other notes:
Looks like /disconnect
was forked off as a separate command here: https://github.com/thelounge/thelounge/commit/047a79ead6b804d5b85bd91b5aada5c3ea3686d1
But /quit
has some extra code to delete the network here (which has apparently been there for years): https://github.com/thelounge/thelounge/blob/8dd9bc0e9813af29fd1a42a33f19c7ffea820e26/src/plugins/inputs/quit.js#L12
Issue Analytics
- State:
- Created 2 years ago
- Comments:7 (4 by maintainers)
Top GitHub Comments
I’ve been bitten by this; I wouldn’t be so irritated about it if it didn’t lose my entire server settings and all the chatrooms I was in with no way to recover them. I had to recover my password and re-set up my auth certificate as well. I don’t think it’s really advisable to let users just say /quit without a confirmation or a prompt.
Love this assumption. I was talking about Colloquy, KVIrc, Textual, and other GUI clients with multi-network capability.
Whatever, as long as we arrive at sensible behavior and/or docs.