Problems with BRICKftp (files.com) server interactions. [Was: The put and fastPut methods have limits in maximum file size]

Like in the https://github.com/jyu213/ssh2-sftp-client/issues/140 is mentioned, these methods don’t work for files > 100kB. But they should work out of the box.

Putting the file content into the readable stream is a workaround, it should be possible to use just sftp.put( src, dest );. Now you need to do something like this instead:

const { Readable } = require( 'stream' );

const fileBody = ( await fs.readFile( src ) ).toString();
await sftp.put( new ReadableStringStream( fileBody ), dest );

class ReadableStringStream extends Readable {
	constructor( str, options ) {
		super( options );
		this.str = str;
	}

	_read( size ) {
		const chunk = this.str.slice( 0, size );

		if ( chunk ) {
			this.str = this.str.slice( size );
			this.push( chunk );
		} else {
			this.push( null );
		}
	}
}

This happens with node 8. Not sure if it crashes also with other node versions.

[theophilusx]

OK, so from that, it is likely something specific to the SFTP server. I have tested against a number of differrent sftp servers and those tests all pass. Given that put works, it is likely something related to the concurrency aspect of fastput. Will be interesting to see if just using the ssh2 streams lib gives the same error (I suspect it will). BTW some of the other tests are failing because the setup hooks also used ssh2-sftp-client and fastPut. I have been working on an lftp wrapper which will make the setup/cleanup independent from the module being tested, but it is still a work in progress!

[theophilusx]

Fixed upstream.