Check In Rewards Redemption Failure

Hello again, Apologise for frequenting too often and making your head spin, I’m sure, but I’ve found a problem and I don’t think it’s within my code. I’m running the following which claims all daily rewards every 24 hours. I also have a gs.set_cookies() function earlier up with connects everyone in the data base.

                while data[key]["check_in_recurring"] is True:
                    await asyncio.sleep(86400)
                    try:
                        gs.hoyolab_check_in(cookie={"ltuid": data[key]["ltuid"], "ltoken": data[key]["ltoken"]})
                        gs.claim_daily_reward(cookie={"ltuid": data[key]["ltuid"], "ltoken": data[key]["ltoken"]})
                        data[key]["last_check_in"] = f"{x.year}-{x.month}-{x.day} {x.hour}:{x.minute}:{x.second} UTC"
                        data[key]["last_check_in_fail"] = [False]
                        save_data()
                        info = gs.get_daily_reward_info(cookie={"ltuid": data[key]["ltuid"], "ltoken": data[key]["ltoken"]})
                        await ctx.send(f"You were checked into HoYoLab and your daily rewards were claimed! You have claimed {info[1]} rewards this month.")
                    except gs.SignInException:
                        data[key]["last_check_in"] = f"{x.year}-{x.month}-{x.day} {x.hour}:{x.minute}:{x.second} UTC"
                        data[key]["last_check_in_fail"] = [True, "already_checked_in_today"]
                        save_data()
                        await ctx.send("You have already checked in today. Please try again tomorrow.")

When I use this, it works perfectly but when another user of the bot tried it, they received the DM that confirms they’ve checked in and that they’ve claimed 5 rewards this month. Whereas in reality, they realised that they had not gotten any mail so they went to the page and it said on there that they had only claimed 4 rewards this month and they had to manually do it. Thoughts?

[thesadru]

From what you’ve said it seems that the request can be successful even when the user was signed in already. This looks more like a bug on mihoyo’s side. I think I can solve it by simply checking if the amount of claimed rewards increased and raising an error manually if not.

I’ll attempt to reproduce this myself just in case the code perhaps failed to raise the error. If you have any other clues about what this might be caused by I’d appreciate it.

[thesadru]

Fair enough, I just thought it could cause some confusion as it did now. Since the bug has been resolved I’ll be closing this issue now.