question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Make length and hashes optional in snapshot/timestamp metadata

See original GitHub issue

Description of issue or feature request:

As per the specification (v1.0.1) length and hashes fields in timestamp and snapshot metadata are optional. The reference implementation should reflect this.

Current behavior:

  • timestamp metadata always includes length and hashes of snapshot metadata (see reposoitory_lib.generate_timestamp_metadata)
  • snapshot metadata always excludes length and hashes of (delegated) targets metadata (see repository_lib.generate_snapshot_metadata)

Expected behavior: Add option to include/exclude these fields in the relevant functions in repository_lib. Since these functions are usually called via write/writeall the option should be made available there too. It’s also conceivable to configure this via attributes on the Repository object.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:1
  • Comments:6 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
MVrachevcommented, Aug 17, 2020

@joshuagl can you close this one? It’s fixed by the above pr.

1reaction
lukpuehcommented, Apr 16, 2020

what should be their default value?

I suggest to choose them so that the default behavior of these functions matches their current behavior.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Create a snapshot | Elasticsearch Guide [8.5] | Elastic
A snapshot repository must be registered and available to the cluster. The cluster's global metadata must be readable. To include an index in...
Read more >
Snapshot Blob (REST API) - Azure Storage | Microsoft Learn
Optional. Specifies a user-defined name-value pair associated with the blob. If no name-value pairs are specified, the operation will copy the ...
Read more >
iceberg/spec.md at master · apache/iceberg - GitHub
The manifests that make up a snapshot are stored in a manifest list file. Each manifest list stores metadata about manifests, including partition...
Read more >
Roles and metadata - The Update Framework
The timestamp.json metadata file lists the hashes and size of the snapshot.json file. This is the first and potentially only file that needs...
Read more >
Configuration - Apache Iceberg
Iceberg tables support table properties to configure table behavior, like the default split size for readers. Read properties. Property, Default, Description ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found