question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

build differs from master

See original GitHub issue

Hey @thomaspark

When I run grunt swatch on the latest master branch, a lot of files get changes. Shouldn’t these files be equal with the committed files? Is there a random salt added?

reproduce with

$ git fetch upstream
$ git merge upstream/master
$ grunt swatch
$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   dist/cyborg/bootstrap.min.css
	modified:   dist/darkly/bootstrap.min.css
	modified:   dist/flatly/bootstrap.min.css
	modified:   dist/litera/bootstrap.css
	modified:   dist/litera/bootstrap.min.css
	modified:   dist/lux/bootstrap.min.css
	modified:   dist/materia/bootstrap.min.css
	modified:   dist/pulse/bootstrap.min.css
	modified:   dist/slate/bootstrap.css
	modified:   dist/slate/bootstrap.min.css
	modified:   dist/solar/bootstrap.min.css
	modified:   dist/superhero/bootstrap.min.css
	modified:   dist/yeti/bootstrap.min.css
	modified:   docs/4/cyborg/bootstrap.min.css
	modified:   docs/4/darkly/bootstrap.min.css
	modified:   docs/4/flatly/bootstrap.min.css
	modified:   docs/4/litera/bootstrap.css
	modified:   docs/4/litera/bootstrap.min.css
	modified:   docs/4/lux/bootstrap.min.css
	modified:   docs/4/materia/bootstrap.min.css
	modified:   docs/4/pulse/bootstrap.min.css
	modified:   docs/4/slate/bootstrap.css
	modified:   docs/4/slate/bootstrap.min.css
	modified:   docs/4/solar/bootstrap.min.css
	modified:   docs/4/superhero/bootstrap.min.css
	modified:   docs/4/yeti/bootstrap.min.css

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
thomasparkcommented, Jan 17, 2018

Hey @m5o, this should be fixed in 517bddd11579b8aa405f30f5959c4aa379d88238. The issue was that both postcss -> minify and minify -> postcss were happening.

0reactions
thomasparkcommented, Dec 10, 2017

I’m noticing a similar thing. Only affects the minified css, but for an untouched theme. Some kind of interaction between the minified css and the postcss script that’s applied afterwards?

One issue is that with each change, the postcss script is run on all themes instead of just the modified one. This should be changed.

But even so, this shouldn’t happen. It seems to be going back and forth between this:

@supports (position: -webkit-sticky) or (position: sticky){.sticky-top{position:-webkit-sticky;position:sticky;top:0;z-index:1020}}.sr-only{position:absolute;width:1px;height:1px;padding:0;overflow:hidden;clip:rect(0, 0, 0, 0);

and

@supports ((position: -webkit-sticky) or (position: sticky)){.sticky-top{position:-webkit-sticky;position:sticky;top:0;z-index:1020}}.sr-only{position:absolute;width:1px;height:1px;padding:0;overflow:hidden;clip:rect(0, 0, 0, 0);

Basically adding/removing the extra parens. Maybe minify after postcss using a postcss-based minifier? Ideas?

Read more comments on GitHub >

github_iconTop Results From Across the Web

In Git how can I see the diff from master to develop?
As explained in these other answers, you can do this by using git-diff to: View all the differences: git diff master..develop.
Read more >
What is the difference between master and develop branch in ...
“main” branch is based on central approach, while “master-develop” branch comes from git-flow approach. According to git flow, developers merge feature branches ...
Read more >
Master branch won't build after develop branch builds ... - GitHub
When we commit to our develop branch the build completes successfully, when we merge to master it doesn't build. Screen Shot 2020-07-28 at...
Read more >
Bachelor's Degree vs. Master's Degree - SNHU
Understanding the differences between a bachelor's degree and a master's degree gives you an idea of how graduate programs build upon undergraduate study....
Read more >
Why GitHub renamed its master branch to main | TheServerSide
The master branch is no different than any other branch in a cloned Git repo, except that historically it's been the default name...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found