Add a possibility to change service name dynamically because of Consul tags

Hello,

At the moment service name is chosen based on first segment in the path. I would like to be able to map one (or multiple) path segments to service name in Consul.

Few examples: authorization => would mapped to authorization.service.web authorization/api => would be mapped to authorization.service.api

Reason for this, that my routes are defined in Consul tags and I would like to use them as a key when selecting service name in Consul. At the moment to achieve this I have to replace whole DownstreamRouteCreator class, while I would be keen to keep custom part as small as possible.

Would you mind if I make a PR for this?

So something like:

    public interface IServiceNameProvider
    {
        string GetServiceName(string upstreamUrlPath);
    }

    public class ServiceNameProvider: IServiceNameProvider
    {
        public string GetServiceName(string upstreamUrlPath)
        {
            if (upstreamUrlPath.IndexOf('/', 1) == -1)
            {
                return upstreamUrlPath
                    .Substring(1);
            }

            return upstreamUrlPath
                .Substring(1, upstreamUrlPath.IndexOf('/', 1))
                .TrimEnd('/');
        }
    }

and use this such provider in CustomDownstreamRouteCreator class.

with best regards

[mantasaudickas]

Will you push some commit soon?

Sorry, no chance…

But you can do it on your own… just IDownstreamServiceFinder should have this signature:

string GetServiceName(HttpRequest request)

[mantasaudickas]

In the example above authorization is like a DNS name, right?

Not really. Path is just a key to configuration item. That item has all necessary information about downstream service.

To be honest - now I would do this PR a bit differently. Finder should take HttpRequest as parameter and then you can have various logics in routing where service instance can be identified by:

• path prefix
• query parameter
• host name
• request header
• even port

In microservices world where services are created and registered kind of dynamically such kind of flexibility is necessary. In our infrastructure there are hundreds of microservices running and routing rules might vary quite a lot thus in application gateway a lot of flexibility is required 😃