Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Angular no longer directly depends on core-js - should not be a peerDependency

See original GitHub issue

Hi there.

https://github.com/angular/angular-cli/blob/master/packages/schematics/angular/workspace/files/package.json.template#L22-L24

Currently, Angular CLI does not require core-js and is not installed. On the other hand, jest-preset-angular has peerDependencies dependencies in core-js.

It seems to me that we will be forced to do unnecessary installations and should be removed dependencies on core-js. Thanks.

Issue Analytics

State:
Created 4 years ago
Reactions:1
Comments:6 (2 by maintainers)

Top GitHub Comments

1reaction

wthocommented, May 15, 2019

According to the commit message https://github.com/angular/angular-cli/commit/a0a583adaaf8e739c375b914f249801660f33334, the “Angular Build System takes care of the dependencies”.

As jest does not use the Angular Build System and requires some library to reflect the metadata in the decorators, my first suggestion would be to make it a dependency.

Do you know how Angular handles the reflection lib? Does it install it on-demand at the first build? Does Angular offer to use other libraries than core-js?

0reactions

wthocommented, Oct 18, 2019

Solved in #315