InlineHtmlStripStylesTransformer is not strict enough

Current Behavior

Any object literals have their property assignments transformed thus causing source code such as:

console.log({
  styles: ['styles.css']
})

to print out

{
  styles: []
}

Expected Behavior

Only object literals passed to @angular/core’s @Component decorator should have it’s property assignments transformed.

[wtho]

Ok, so one more thought I just had, templateUrl is actually more important to be transformed than styles to be removed. Without templateUrl being transformed to template, it will not even load.

styles on the other hand is just removed for performance issues (correct me if I’m wrong), as we assume styles are usually not tested in jest, that is better done in e2e frameworks.

Proposal

We could also think about handling them differently, although this might complicate the code unnecessarily.

templateUrl:

• replaced everywhere
• alternatively only (as suggested by @FrozenPandaz) in files where Component gets imported from @angular/core or TestBed gets imported from @angular/core/testing

styles:

• replaced only if declared directly inside component decorators

This would seem more practical to me as styles is also used in more contexts than templateUrl.

[wtho]

Yeah, I am almost done with the PR, will submit it this weekend.

It’s not really an error, it is an intrusive caveat that kept the transformer simple, but can create side-effects.