[BUG] The router is unable to add Starlette's HTTPEndpoint

Describe the bug I cannot find a way to add Starlette’s HTTPEndpoint onto app.router.

To Reproduce Steps to reproduce the behavior:

1. Create app: app = fastapi.FastAPI()

2. Create an endpoint:

class HealthHandler(starlette.endpoints.HTTPEndpoint):
    async def get(self, request):
        return starlette.responses.JSONResponse({'status': 'OK'})

1. I am stuck now, I cannot see a way to add HTTPEndpoint into app.router.

Expected behavior Able to add HTTPEndpoint class.

Environment:

• OS: macOS

• FastAPI Version: fastapi==0.29.1

• Python version: 3.7.3

[stefanondisponibile]

That’s not really how FastAPI’s meant to look like. However, if you wanted to define an endpoint that way, remember you are in a Starlette environment:

FastAPI is actually a sub-class of Starlette.

Therefore, what you could do is:

# main.py
from fastapi import FastAPI
from starlette.endpoints import HTTPEndpoint
from starlette.responses import JSONResponse

app = FastAPI()

@app.route("/")
class HealthHandler(HTTPEndpoint):
    async def get(self, request):
        return JSONResponse({'status': 'OK'})

uvicorn main:app
# INFO: Started server process [19630]
# INFO: Waiting for application startup.
# INFO: Uvicorn running on http://127.0.0.1:8000 (Press CTRL+C to quit)
# INFO: ('127.0.0.1', 50608) - "GET / HTTP/1.1" 200 ==> {"status":"OK"}

[HarrySky]

@stefanondisponibile @didip Starlette (and FastAPI as subclass) has add_route method so there is no need to create cyclical dependencies:

#health_handler.py

from starlette.endpoints import HTTPEndpoint
from starlette.responses import JSONResponse

class HealthHandler(HTTPEndpoint):
    async def get(self, request):
        return JSONResponse({'status': 'OK'})

# main.py
from fastapi import FastAPI
from health_handler import HealthHandler

app = FastAPI()
app.add_route(path="/", route=HealthHandler)