question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

My PR don't have the "approved-2" label

See original GitHub issue

First Check

  • I added a very descriptive title to this issue.
  • I used the GitHub search to find a similar issue and didn’t find it.
  • I searched the FastAPI documentation, with the integrated search.
  • I already searched in Google “How to X in FastAPI” and didn’t find any information.
  • I already read and followed all the tutorial in the docs and didn’t find an answer.
  • I already checked if it is not related to FastAPI but to Pydantic.
  • I already checked if it is not related to FastAPI but to Swagger UI.
  • I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

  • I commit to help with one of those options 👆

Example Code

N/A

Description

I make a PR : https://github.com/tiangolo/fastapi/pull/5477 And 2 persons already approve it : emmrichard and rjNemo but the bot didn’t add the approved-2 label.

Futhermore, some PR have this label and aren’t merge to the master branch : https://github.com/tiangolo/fastapi/pulls?q=is%3Aopen+is%3Apr+label%3Aapproved-2

I’m pretty sure that I forgot something to do, but I don’t know what.

Thank you for your advice.

Operating System

Linux

Operating System Details

N/A

FastAPI Version

0.85.1

Python Version

3.10

Additional Context

N/A

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
axel584commented, Nov 7, 2022

Thanks!

1reaction
tiangolocommented, Nov 7, 2022

Hey there! Yep, the label is added only to PRs that have the labels for “lang-all” and “awaiting review”. You did nothing wrong, I just hadn’t added those labels.

Thanks for help @iudeen !

🍰☕

Read more comments on GitHub >

github_iconTop Results From Across the Web

Understanding Unapproved Use of Approved Drugs "Off Label"
One reason is that there might not be an approved drug to treat your disease or medical condition. Another is that you may...
Read more >
Managing labels - GitHub Docs
You can manage your work on GitHub by creating labels to categorize issues, pull requests, and discussions. You can apply labels in the...
Read more >
Ten Common Questions (and Their Answers) About Off-label ...
Off-label drug use involves prescribing medications for indications, or using a dosage or dosage form, that have not been approved by the US...
Read more >
Automatically check that pull request has a label before merging
Yes, It's possible. In general there are at least two ways of doing that. First one I don't like, but it might be...
Read more >
Converting Labeling for Older Drugs from the Old Format to ...
Farrokh Sohrabi, CDER Office of New Drugs, provides an overview of Physician Labeling Rule (PLR) conversion principles for older drugs based ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found