question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

My PullRequest (translation of documentation) broke units tests...

See original GitHub issue

First Check

  • I added a very descriptive title to this issue.
  • I used the GitHub search to find a similar issue and didn’t find it.
  • I searched the FastAPI documentation, with the integrated search.
  • I already searched in Google “How to X in FastAPI” and didn’t find any information.
  • I already read and followed all the tutorial in the docs and didn’t find an answer.
  • I already checked if it is not related to FastAPI but to Pydantic.
  • I already checked if it is not related to FastAPI but to Swagger UI.
  • I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

  • I commit to help with one of those options 👆

Example Code

N/A

Description

I translated a page of the documentation in french, and make a Pull Request : https://github.com/tiangolo/fastapi/pull/5477

And the CI/CD shows 2 problems with the Unit Test (for the 3.7 and 3.9 plateform) : https://github.com/tiangolo/fastapi/actions/runs/3215376279/jobs/5256425256 https://github.com/tiangolo/fastapi/actions/runs/3215376279/jobs/5256425208

I don’t understand why (I just add .md file).

The log explains :

        modulename = "anyio._backends._" + asynclib_name
        try:
>           return sys.modules[modulename]
E           KeyError: 'anyio._backends._trio'

/opt/hostedtoolcache/Python/3.9.14/x64/lib/python3.9/site-packages/anyio/_core/_eventloop.py:153: KeyError

Is it a missing module in the runner of the CI/CD ? To be honest, it’s outside of my skills… Thanks for your help.

Operating System

Other

Operating System Details

the runner of the CI/CD : https://github.com/tiangolo/fastapi/actions/runs/3215376279/jobs/5256425256 https://github.com/tiangolo/fastapi/actions/runs/3215376279/jobs/5256425208

FastAPI Version

0.85.0

Python Version

3.7 and 3.9

Additional Context

No response

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:7 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
mbrotoncommented, Oct 10, 2022

Hi, the cause of these problems is identified and fixed here: https://github.com/tiangolo/fastapi/pull/5456 But it’s not merged yet 😔

1reaction
iudeencommented, Oct 31, 2022

No, not your fault.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Add Spanish translation for docs/tutorial/response-status-code ...
According to the Spanish Translation feature: #1218 This pull request includes the ... My PullRequest (translation of documentation) broke units tests.
Read more >
Submit your first Pull Request! (Github Actions, Unit tests ...
Things you need to know about making that first pull request and finally getting on your way to contributing to open source!
Read more >
No Tests - No Pull Request, Right? Types of Tests that Should ...
Yes, your unit test should not perform I/O operations, like reading/writing data from a database, performing HTTP calls and so on. Check a...
Read more >
Describing Pull Requests
The first step is to write a summary of your pull request's purpose in its ... Including automated tests (unit, integration or functional)...
Read more >
Pull requests - Mautic Community Handbook
You're almost ready to submit your pull request! There's three things we still need to look into: Code Standards; End-user documentation; Writing tests....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found