Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add file extensions to generated imports.

See original GitHub issue

Files generated by the protoc plugin, currently, import witht he following syntax import {x} from 'y' however for reasons outlined in https://github.com/nodejs/modules/issues/444, the following syntax should be used for forward compatibility with esmodules import {x} from 'y.js'

Further reading: https://nodejs.org/api/esm.html#import-specifiers https://devblogs.microsoft.com/typescript/announcing-typescript-4-5-beta/

Issue Analytics

State:
Created 2 years ago
Reactions:2
Comments:6 (3 by maintainers)

Top GitHub Comments

2reactions

nvandammecommented, Feb 27, 2022

#233

0reactions

timostammcommented, Nov 6, 2021

There is also the deprecated packages/plugin-framework/src/typescript-import-manager.ts, which can be ignored - it is not used anymore.

There is a spec file for parts of typescript-imports.ts. It is probably best to extend the test coverage a bit (its not actually covering TypeScriptImports yet) and implement against it.

I don’t think it will be feasible to add test coverage in @protobuf-ts/plugin, because if I’m not mistaken, it uses a TypeScript version that does not support the .js imports yet.