App.use does not alter request path for middleware

Describe the bug

The sirv or serve-static middleware does not serve files when putting it under another path in the router. It does work when the mount path is / or corresponds with the filesystem.

To Reproduce

import { App } from "@tinyhttp/app";
import serveStatic from "serve-static";
import sirv from "sirv";

new App()
  .use("/static", sirv("dist/client"))
  .use("/static2", serveStatic("dist/client"))
  .use("/pages", sirv("dist/client"))
  .listen(3000);

$ curl http://localhost:3000/static/pages/index.js
Not found
$ curl http://localhost:3000/static2/pages/index.js
Not found
$ curl http://localhost:3000/pages/index.js
console.log("hi");

Expected behavior

$ curl http://localhost:3000/static/pages/index.js
console.log("hi");
$ curl http://localhost:3000/static2/pages/index.js
console.log("hi");
$ curl http://localhost:3000/pages/index.js
Not found

Versions

• node: v14.13.0
• @tinyhttp/app: ^1.0.14

Additional context

$ tree dist/client
dist/client
└── pages
    ├── index.js
    ├── index.js.map
    ├── outdex.js
    └── outdex.js.map

[talentlessguy]

@calumk looks like it’s a subapp issue. Subapp handles all the paths starting with /, leading to paths in the original apps getting ignored

will close this issue and open a new one

[talentlessguy]

ok so what express does is that it strips the path, e.g. /static, from req.url and req.path

but it remains in req.originalUrl

will fix it in a moment 😄