question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Mobile version of TinyMCE should respect the noneditable plugin when using Silver theme

See original GitHub issue

Do you want to request a feature or report a bug? Bug

What is the current behavior? Noneditable elements are freely editable when using a mobile version of TinyMCE that uses Silver theme instead of full screen editor.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via fiddle.tinymce.com or similar. Setup TinyMCE with the noneditable plugin and Silver theme for mobile instead of full screen editor, and specify that elements of a certain class should be noneditable.

tinymce.init({
  selector: "textarea",
  plugins: "noneditable",
  noneditable_noneditable_class: "mceNonEditable",
  mobile: {
    theme: 'silver',
  },
});

Using desktop browser, add some elements through source code that contain the specified noneditable class. Test in desktop browser and observe that noneditable elements are not editable. Then, switch to a mobile device and observe how the noneditable elements ARE freely and fully editable (bug).

Now, remove the silver theme from the mobile setup, and test again using the fullscreen editor in your mobile device. Observe how the noneditable areas ARE NOT editable (correct).

What is the expected behavior? Expected behaviour is that the mobile version of TinyMCE respect the noneditable setup, even when using the Silver theme instead of fullscreen editor.

Which versions of TinyMCE, and which browser / OS are affected by this issue? Did this work in previous versions of TinyMCE? TinyMCE v5.0.1 (2019-02-21) Chrome 72.0.3626.119 (Official Build) (64-bit) Opera 58.0.3135.68 Opera for Android v49.2.2361.134358 Chrome for Android v71.0.3578.99 Android 9

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:12 (7 by maintainers)

github_iconTop GitHub Comments

3reactions
TheSpydercommented, Feb 27, 2019

We’ve realised that the way we turned mobile on by default in v5 has changed the plugin defaults as well. Even though using desktop themes on mobile isn’t something we test, we’re going to log a task to link the plugin whitelist to the theme instead of the platform which should allow v4-like behaviour with using desktop themes on mobile if desired.

1reaction
lnewsoncommented, Feb 26, 2019

I checked with the team and the silver theme currently isn’t supported in mobile mode unfortunately, so it is behaving correctly as those three plugins are the only supported plugins for mobile mode.

In which case, I’ll turn this into a feature request to be able to support silver and additional plugins for mobile.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Working with noneditable content in TinyMCE
The TinyMCE noneditable plugin is used to mark specific elements as not editable by your authors. This can be incredibly useful when you ......
Read more >
TinyMCE 6.0: Core changes
Premium Plugins released with TinyMCE 6.0 are not backwards compatible with ... autocompleter feature from the default silver theme to the TinyMCE core, ......
Read more >
TinyMCE 3.x FAQ
Why would you need to limit the number of characters a user can input into the editor? What do you need WYSIWYG for?...
Read more >
Changelog | Docs - TinyMCE
Clicking beside a non-editable element could cause the editor to incorrectly scroll to the top ... Changed mobile phones to use the silver...
Read more >
Changelog | TinyMCE Documentation
This is the TinyMCE Community version changelog. ... Add-ons such as plugins and themes are no longer constructed using the new operator.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found