New option in Media plugin settings to add a callback for external embeds

I need to wrap the embeds/iframes with a div in order to make them responsive. For now the only way I found to do that is implementing a new plugin for pasting the iframe code. I think it’s a waste of time making a new plugin just for that, so it would be better/easier if the Media plugin would allow adding a callback for embeds in the same way than video_template_callback for videos. Something like embed_template_callback.

[JayAdra]

+1

Also when putting a YouTube or Vimeo link in Source field, the editor ignores my “video_template_callback” and puts its own code?

We need to be able to control the markup for all videos and embeds.

[ahaverty]

@thedrjim It would be great to have a “iframe_template_callback” setting for the media plugin.

Workaround in the meantime: https://github.com/tinymce/tinymce/blob/e25ec422bcf3889fc47aa46f0a230666a21b5e22/modules/tinymce/src/plugins/media/main/ts/core/DataToHtml.ts#L22 I tracked down the template code (☝️), and put in a dirty workaround in one of my (ruby on rails) helper’s:

  def responsive_iframe_embed(html)
    html.gsub("<iframe", '<div class="embed-responsive embed-responsive-16by9"><iframe class="embed-responsive-item" ').gsub("</iframe>", "</iframe></div>")
  end

And an example of using it in one of my views:

<%= responsive_iframe_embed(@apartment.apartment_type.description).html_safe %>

Not ideal, but it’s working for us.