Docs for paymentRequestWithNativePay incomplete/inconsistent
See original GitHub issueBefore I have submitted the issue
[x] I have read an installation guide
[x] I know that for an iOS I need to install pods because I’ve read the installation guide
[x] I have read a linking guide and checked that everything is OK like in manual linking guide
[x] I know that before using tipsi-stripe
I need to set options for my app as described in usage guide
The problem
The methods signatures for paymentRequestWithApplePay(items, options)
and paymentRequestWithNativePay(options, items)
are inconsistent.
https://github.com/tipsi/tipsi-stripe/blob/master/src/Stripe.js#L74
vs.
https://github.com/tipsi/tipsi-stripe/blob/master/src/Stripe.js#L87
Also, the documentation mentions that paymentRequestWithNativePay
is preferred, but doesn’t indicate the new parameter order.
The Solution
Update docs or change method signatures to always go in (items, options)
order.
Environment
tipsi-stripe
version: Latest
Issue Analytics
- State:
- Created 4 years ago
- Reactions:10
- Comments:6
Top GitHub Comments
@Adokiye I found the source code to be the most useful documentation for this project.
You can see the interfaces here https://github.com/tipsi/tipsi-stripe/blob/d9c8be08b7ce3757f6bc5ee5198f46c63a38e2c1/src/Stripe.js#L64 which is helpful for knowing which interface methods expect which types.
And https://github.com/tipsi/tipsi-stripe/blob/d9c8be08b7ce3757f6bc5ee5198f46c63a38e2c1/src/utils/types.js#L132 for seeing the type definitions
Can’t find the documentation for paymentRequestWithNativePay anywhere, please can someone post a link or something, I don’t even know the parameters to pass to the endpoint