Cronjob is run every time runcrons is called

We just noticed some strange behaviour on our staging server after updating from django-cron 0.4.6 to 0.5.0. One of our jobs looks like this:

class AnalyticsReportJob(CronJobBase):
    RUN_EVERY_MINS = 60 * 24

    schedule = Schedule(run_every_mins=RUN_EVERY_MINS)
    code = 'analytics.report'

    def do(self):
        do_stuff()

It’s supposed to report on gathered analytics data once a day, basically just collecting and sending out some emails. Real cron is calling runcrons every minute. After experiencing some heavy load and unexpected behaviour, we could confirm that do_stuff() is actually executed every minute, leading to several critical issues including zombie processes.

[pvojnov]

Hi, i have the same issue but the provided fix didn’t solve it.

By looking at the code it seems that the CronJobLog record doesn’t get inserted to the database until the job finishes. That way the query in CronJobManager.should_run_now wont find the job that is already running and start the job again before the first one finishes.

I’ve made a quick fix to CronJobManager.run by adding: self.make_log('Job Running!!', success=True) Just before the line: self.msg = self.cron_job.do()

And it works!! 😃

[sulami]

I don’t have access to the environment in question anymore, but we did use USE_TZ, and I’m pretty sure the servers were in Ireland (AWS).