Migrating from express-saml2
See original GitHub issueHi. Thanks for all the work you put in on this. I’m looking at the steps needed to change over from express-saml2 to samlify and I have a question about the sample. I used the IdP, SP1 and SP2 samples from express-saml2 to figure out how to implement. The sample code in this doc has just about everything I have, but in my code I have a handler for * that checks the storage and re-directs.
// Send all requests to index.html so browserHistory works app.get('*', function (req, res) { if (cookieVault.read(req) === COOKIE_CODE) { res.sendFile(path.join(__dirname, publicPath, 'index.html')) } else { if (!req.url.includes('favicon')) res.redirect('/sso/login'); } })
The sample at samlify-sp is nothing like the express sample in the doc. Is there a finished sample that uses the code from the OneLogin doc? I’d like to make sure I’m handling all the routes correctly.
Thanks, Mike
Issue Analytics
- State:
- Created 6 years ago
- Comments:6 (3 by maintainers)
Top GitHub Comments
Hey Tony,
I finally got around to writing that article on my experience putting samlify to work in AWS. If you’re interested you can find it here for the time being…
http://relianceinteractive.com/Articles/angularjs-aws-and-sso/angularjs-aws-and-sso.htm
Let me know if you want me to make any corrections.
Mike
From: Michael Baker [mailto:Mike.Baker@RelianceInteractive.com] Sent: Friday, May 04, 2018 1:34 PM To: ‘tngan/samlify’ Subject: RE: [tngan/samlify] Migrating from express-saml2 (#169)
Thanks! J
From: Tony Ngan [mailto:notifications@github.com] Sent: Friday, May 04, 2018 11:55 AM To: tngan/samlify Cc: Mike Baker; Mention Subject: Re: [tngan/samlify] Migrating from express-saml2 (#169)
@mikevbaker https://github.com/mikevbaker The documentation has been finally updated for the change.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tngan/samlify/issues/169#issuecomment-386662484 , or mute the thread https://github.com/notifications/unsubscribe-auth/ABOEKlGcMZjrIvpniTqLzz_8k7TTAp9hks5tvIfbgaJpZM4SnyjF . https://github.com/notifications/beacon/ABOEKuqJEVQSQU_zPtROd-cBxny0mM7Sks5tvIfbgaJpZM4SnyjF.gif
Thanks! J
From: Tony Ngan [mailto:notifications@github.com] Sent: Friday, May 04, 2018 11:55 AM To: tngan/samlify Cc: Mike Baker; Mention Subject: Re: [tngan/samlify] Migrating from express-saml2 (#169)
@mikevbaker https://github.com/mikevbaker The documentation has been finally updated for the change.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tngan/samlify/issues/169#issuecomment-386662484 , or mute the thread https://github.com/notifications/unsubscribe-auth/ABOEKlGcMZjrIvpniTqLzz_8k7TTAp9hks5tvIfbgaJpZM4SnyjF . https://github.com/notifications/beacon/ABOEKuqJEVQSQU_zPtROd-cBxny0mM7Sks5tvIfbgaJpZM4SnyjF.gif