Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Allow positional arguments to PClass.init

See original GitHub issue

PClass subclasses must be given keyword arguments for initialization, currently. This is often quite a good thing. However, particularly for a type with only one field, the ability to use a positional argument instead is rather convenient.

Compare:

self.assertThat(foo, MappingLikeEquals(expected=bar))`

self.assertThat(foo, MappingLikeEquals(bar))`

It’s hardly an earth shattering difference but I don’t find the keyword argument adds anything to the former (and it stands out against the idiom of the API it’s being used with, which includes other such types as Equals(bar), Contains(bar), etc).

Issue Analytics

State:
Created 7 years ago
Comments:9 (5 by maintainers)

Top GitHub Comments

1reaction

exarkuncommented, Sep 7, 2017

Order can be captured in other ways. For example, field could have an internal monotonic counter set at instantiation time. The order of fields in the PClass is then trivially extracted by ordering the fields by their value of this counter.

0reactions

tobgucommented, Jul 3, 2021

Closing due to staleness, please reopen if anyone wants to act on this!