Dealing with whitespaces

  let str = '<?xml version="1.0" encoding="UTF-8" standalone="yes"?><w:document xmlns:w="http://schemas.openxmlformats.org/wordprocessingml/2006/main"><w:body><w:p><w:r><w:t>aaaaa</w:t></w:r><w:r><w:rPr><w:sz w:val="48"></w:sz></w:rPr><w:t>       </w:t></w:r><w:r><w:t>bbbbbb</w:t></w:r></w:p><w:sectPr><w:pgSz w:w="793.7008056640625" w:h="1122.5196533203125" w:orient="portrait"></w:pgSz><w:pgMar w:top="95.99999237060547" w:right="119.81102752685547" w:bottom="95.99999237060547" w:left="119.81102752685547" w:header="47.24409484863281" w:footer="47.24409484863281" w:gutter="0"></w:pgMar></w:sectPr></w:body></w:document>';
  const resut = txml.parse(str);

Note the <w:t> </w:t> part. Checking the result object, that ‘w:t’ item has an empty ‘children’ array: children: [].

After reading source code, it seems that parseChildren function has the following lines:

var text = parseText()
if (text.trim().length > 0)
    children.push(text);
pos++;

text.trim()causes the issue. Is there any particular purpose ‘trim()’ is needed here? Or am I missing something in the process?

Thanks!

[ConradHughes]

Cool. Just to be clear, what I mean is that the current code doesn’t trim text, even though it thinks it does:

    var text = parseText()
    if (keepWhitespace || text.trim().length > 0)
        children.push(text);
//                    ^^^^--- not trimmed!

… if I txml.parse('<tag> text </tag>', { simplify: true }), I get { tag: ' text ' }, where I think the expectation is that it should be { tag: 'text' }…

[TobiasNickel]

the current code is this: https://github.com/TobiasNickel/tXml/blob/master/tXml.js#L146

    var text = parseText()
    if (keepWhitespace || text.trim().length > 0)
        children.push(text);

with it, when the developer want to keepWhitespace the value is kept anyway. But I think that your solution is still better. because it will be more consistent with removing whitespace when not keeping whitespace.

The code for the next version has already updated to allow smaller bundles. this is an other great change for version 5. Thanks for your feedback. I think at the weekend I will prepare the version 5 update for npm.