Some tests do not use conftest.data_dir() to find test data

I’m setting up for a test infrastructure that gets the test data from somewhere not near the current working directory of the test. It would be much easier to control this if everything consistently used conftest.data_dir(). test_read_drivers.py does not. Here is what I ended up with:

import logging
import os
import sys

import conftest
import pytest

import fiona
from fiona.errors import FionaValueError

def test_read_fail():
    filepath = os.path.join(conftest.data_dir(), 'coutwildrnp.shp')
    with pytest.raises(FionaValueError):
        fiona.open(filepath, driver='GeoJSON')
    with pytest.raises(FionaValueError):
        fiona.open(filepath, enabled_drivers=['GeoJSON'])


def test_read():
    filepath = os.path.join(conftest.data_dir(), 'coutwildrnp.shp')
    with fiona.open(filepath, driver='ESRI Shapefile') as src:
        assert src.driver == 'ESRI Shapefile'
    with fiona.open(filepath, enabled_drivers=['GeoJSON', 'ESRI Shapefile']) as src:
        assert src.driver == 'ESRI Shapefile'

[snorfalorpagus]

I agree that some consistency would be nice.

The data_dir function is actually a pytest fixture, so you can use it as below - you don’t even need to import conftest for this to work:

def test_read_fail(data_dir):
    filepath = os.path.join(data_dir, 'coutwildrnp.shp')
    with pytest.raises(FionaValueError):
        fiona.open(filepath, driver='GeoJSON')
    with pytest.raises(FionaValueError):
        fiona.open(filepath, enabled_drivers=['GeoJSON'])

@schwehr Would you be willing to make a PR to this effect?

[QuLogic]

When locally testing, I use -e which works all the time, since there’s never multiple copies of things to confuse pytest.

On Fedora, we test the installed package, but the installed package is in a temporary buildroot. So -e is not really useful since we want to test the install, not some intermediary. Instead, PYTHONPATH is set to look in the temporary location. Because of the extensions, the problem that we run into is not about conftest, but rather that the source fiona directory comes first in the search path. So as a workaround, I delete the source fiona, which is basically the same as what you do on Travis.

So I don’t seem to run into this issue anymore, either because there are never two copies of anything around to confuse pytest, or because of the other fixes that went in between the alpha and the final release.