question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Considering switching to airbnb styleguide

See original GitHub issue

https://github.com/airbnb/javascript

Right now we extend react-app’s eslint configuration with a few additions such as quotes, jsx-quotes and comma dangle. It’s great that we have a styleguide in place but it would be helpful for future contributors to take on a canonical and idiomatic way of writing modern javascript.

This issue is more of a discussion piece before I do a quick refactor. Input appreciated 👍

For reference, our styles:

https://github.com/tomchentw/react-google-maps/blob/master/.eslintrc

{
  "extends": "react-app",
  "rules": {
    // Possible Errors
    "comma-dangle": ["error", "always-multiline"],
    // Stylistic Issues
    "jsx-quotes": ["error", "prefer-double"],
    "quotes": ["error", "backtick"]
  }
}

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:7 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
tomchentwcommented, Jul 27, 2017

I’d like to keep trailing commas (and this can be done by prettier). backtick is just one of my personal preferences. Feel free to switch to either single or double quotes.

0reactions
tomchentwcommented, Sep 14, 2017

Switched to prettier in v8.0.0 https://tomchentw.github.io/react-google-maps/

Read more comments on GitHub >

github_iconTop Results From Across the Web

Consider switching to Airbnb JavaScript Style Guide · Issue #20
Consider switching to Airbnb JavaScript Style Guide #20. Open. frangio opened this issue on Sep 9, 2019 · 0 comments.
Read more >
Quick Set up Eslint with Airbnb Style Guide. - Medium
In this blog post, I would be explaining how to set up eslint with airbnb style guide and I hope it won't take...
Read more >
8 Noteworthy Points from AirBnb's JavaScript Style Guide
There are far more than 8 points to consider if you want to adhere towards AirBnb's JavaScript style guide. Of course, you can...
Read more >
Why you should adopt a community-maintained javascript ...
Airbnb's JavaScript style guide is very popular. Here's why you should use a community-maintained style guide for code standardization.
Read more >
JavaScript Style Guides: What are they and which one to use?
Some example style guides we'll look at in the video are the: - Google JavaScript style guide - AirBnB style guide - Standard.js...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found