Open to cheap FeedbackCombFilter?

The recent change to use ConvolverNodes in Freeverb and JCReverb has lead to greater quality in those nodes, however; as noted (https://github.com/Tonejs/Tone.js/issues/637 https://github.com/Tonejs/Tone.js/issues/637) it’s also introduced some performance issues on lower-powered devices.

In order to avoid some pretty bad audio glitches on mobile Safari, I’ve done the following in my project:

• introduced the non-convolver-based FeedbackCombFilter back in to my project and named it FeedbackCombFilterCheap
• created a LowpassCombFilterCheap that uses that
• created JCReverbCheap and FreeverbCheap that use the above two nodes in place of the non-cheap versions

Would that helpful to pull into Tone.js? Otherwise, the above solution may help other folks looking for a workaround

[JackCA]

Sorry for the delayed response here.

That test does indeed seem to prove that my assumption about the convolution nodes was incorrect. Apologies for the misdirect.

I believe what I was experiencing was related to the perf issues I was seeing with https://github.com/Tonejs/Tone.js/issues/686.

Thanks! ☮️

[tambien]

So here’s a not very scientific test which compares the old (version 13.8.25) Tone.Freeverb to Tone.Reverb. You can alter the count and useFreeverb variables to test out the performance. For me, Tone.Reverb on Chrome lasts just slightly longer before crackling or going silent than Tone.Freeverb and on Safari Tone.Reverb works much better than Tone.Freeverb.

That is to say that, i’m not sure there is such a big enough performance benefit of the FeedbackCombFilter-based reverbs over Convolution-based to justify all of the overhead of maintaining two versions of each of the classes.