No popup for ANY image I mouseover
See original GitHub issueThe commit: handle autoscaled SVG + code cosmetics (which was the 4th after the release of v1.1.3), has caused me the following:
from that point, there’s no popup with the full image for ANY image I mouseover anymore,
the image zoom becomes displayed as NaN%
at some point,
but the accompanying text is displayed ok (but only that) on the upper part of the page,
and pressing t
(open in new tab) or d
(download image) both still work ok.
Note: the version before that commit, i.e. https://github.com/tophf/mpiv/commit/174366ed6cc328564e3df7487f07a7562c02c62b works fine.
STR in a fresh Chrome profile with only Tampermonkey beta/Violentmonkey and the script of https://github.com/tophf/mpiv/commit/3e1ade87cd2c1450024fb099b2f5a81e9f34f052
- import my various rules (see below)
- go to e.g. https://www.instagram.com/instagram/
- hover any image. Notice the following:
- the cursor spins forever as I mouseover any video thumbnail
- there’s no popup (with the full image) for ANY image I mouseover,
- the first time I mouseover any image, the accompanying text of the relevant post is displayed on top of the page ok (but there’s no zoom info, image dimensions or MP).
If I mouseover again, then the zoom level is displayed as
NaN%
e.g. - pressing
t
(open in new tab) ord
(download image) both still work ok.
The rules that I import, are too many to post them here, so, I attach them as text file: my rules.txt
Issue Analytics
- State:
- Created 4 years ago
- Comments:9 (6 by maintainers)
Top GitHub Comments
Fixed in 06fb865c.
Fixed now in MPIV.
The problem was exacerbated by the following rule:
It should be
"(\\.uvnimg\\.com/.*?/)\\?url=(.*)"
or"(^.*?\\.uvnimg\\.com/.*?/)\\?url=(.*)"
You’re using an unnecessary
.*
in many of your rules, for example:.*\\.(jpe?|pn)g.*
should be\\.(jpe?|pn)g
because you’re not using those parts covered by.*
anywhere. The “greedy”.*
is a known cause for catastrophic backtracking so it may take minutes to resolve. If you absolutely have to use it, prefer its non-greedy version.*?
or find about other ways to safeguard against catastrophic backtracking like positive/negative lookahead.