question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Questions of several implementation details

See original GitHub issue

Hello @ku2482

May I ask you several implementation details and why you made these decisions?

  1. In this line, you compute signs by comparing sa_quantiles[I] with sa_quantiles[i-1](except the first one). Why don’t you use values_1>0 as the signs?
  2. In this line, you initialize the weights of the FractionProposalNetwork using Xavier initialize with gain=0.01. What makes you choose this initialization?

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:10 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
toshikwacommented, Sep 3, 2020

Hi @xlnwel

1 When F_Z^{-1}(w) is non-decreasing, the sign is +1 and gradients are the same as Proposition 1.

However, when F_Z^{-1}(w) is decreasing, the assumption of Proposition 1 doesn’t hold anymore. In this case, I correct the gradients setting the sign to -1.

2 It’s hand-designed by me.

The weights of the fraction proposal network are initialized so that initial probabilities are uniform as in QR-DQN

The author mentioned above in the paper, so I made the weight smaller so that initial probabilities are closer to the uniform distribution and the initialization was less influential.

Thanks 😃

0reactions
xlnwelcommented, Sep 6, 2020

Hi @ku2482

No problem. May I ask what your position is right now? Maybe we can share some thoughts after the challenge is completed.

Read more comments on GitHub >

github_iconTop Results From Across the Web

What is an implementation detail? - Enterprise Craftsmanship
Making implementation details public means you allow the clients of the class to depend on those details causing all sorts of issues related ......
Read more >
Expounding implementation details of a paper and provide a ...
I've done a detailed analysis that wasn't provided by the original paper, like predicting solution in some cases, computational complexity.
Read more >
Is hiding implementation detail Encapsulation or Abstraction?
In this SO question top answer : abstraction = the object externally; encapsulation (achieved through information hiding) = the object ...
Read more >
Solved C# programming Question 1 : Implementation | Chegg ...
Question 1 : Implementation details of Address class: Add and implement a class named Address according to specifications in the UML class diagram....
Read more >
Default Methods - The Java™ Tutorials - Oracle Help Center
See JDK Release Notes for information about new features, enhancements, ... have implemented those interfaces would have to rewrite their implementations.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found