Fails to load .gdo gerber files

Tried to upload a set of Gerber Files exported from Mentor PADS (extension .gdo).

Error I get is: Uncaught TypeError: Cannot read property 'type' of undefined from _pad-shape.js:239

Those few lines of code:

var runMacro = function(mods, blocks) {
  var emptyMacro = {shape: [], box: boundingBox.new()}
  var exposure = 1

  blocks = blocks || []

  return blocks.reduce(function(result, block) {
    var shapeAndBox

    if (block.type !== 'variable' && block.type !== 'comment') {

Line 239 is the last line^, looks like block is undefined… not sure if there needs to be some type of parsing adding for Mentor files, or if there just needs to be a check that returns from the function if block===undefined

[mehulmshah]

@kasbah Adding that check prevents the error and allows the gerbers to render. Now the issue is that the gerbers are rendered slightly incorrectly (but this is at least better than the code breaking!)

I have found the issue for my gerber set – the gerber specifies G74* (Disable 360° circular interpolation (single quadrant)) When I change that to G75* (Enable 360° circular interpolation (multiquadrant)), the Gerber renders correctly. Maybe this is something that needs to be added into Gerber Settings? I’ll look into how easy that is and if I can just make a PR.

[mehulmshah]

Ah yeah you’re correct, I think #82 is the more relevant one. I emailed you & @kasbah the files for this issue if you wanted to take a closer look.