Stuck on an issue?
Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Companion improvements
See original GitHub issueDiscovered while working on #3159:
- speed improvement: For TUS uploads (and I believe form upload), we don’t need to download file first, even if its size is unknown. I think those can both handle unknown length streams
- pause/resume tus upload does not work properly with
streamingUpload: true(currently defaults to false), due to this issue: tus/tus-js-client#275 - We should consider adding support for URL objects instead of using
path - https://github.com/transloadit/uppy/issues/3545
Discovered while working on #3953
- upgrade
gotto v12, so that we can get rid of the unmaintainedform-datamodule, see #3496. This might be a big task because we possibly would need to rewrite Companion to ESM. -
/logoutendpoint in companion has side effects and I think should not be aGET(this is a client-server API breaking change so maybe it won’t happen ever) https://github.com/transloadit/uppy/blob/727fbc6398c6009c6c98b4d9fcf285b00983ec8d/packages/%40uppy/companion/src/companion.js#L116
Moved from trello
- make Instagrams thumbnails smaller, maybe transcode them on-the-fly in companion
Write tests:
- Unsplash, similar to all the other providers
- test for: https://github.com/transloadit/uppy/blob/84a98c607c501ba28ba326d070fc32283f3deef1/packages/%40uppy/companion/src/server/Uploader.js#L621
- test for: https://github.com/transloadit/uppy/blob/84a98c607c501ba28ba326d070fc32283f3deef1/packages/%40uppy/companion/src/server/helpers/request.js#L155
- test for: https://github.com/transloadit/uppy/blob/84a98c607c501ba28ba326d070fc32283f3deef1/packages/%40uppy/companion/src/server/helpers/utils.js#L160
Issue Analytics
- State:
- Created 2 years ago
- Comments:6 (3 by maintainers)
Top Results From Across the Web
New American Airlines Companion Upgrade Policy
All AAdvantage elites now receive complimentary space-available upgrades on all flights within North America. A companion traveling with ...
Read more >Companion Riding Improvements - No Man's Sky
Increases companion riding speed, reduces stamina drain, improves camera rotation range, reduces steering weight, and reduces the ...
Read more >Companion armor | Dragon Age Wiki - Fandom
Armor upgrades simply add 10% to the companions' armor value, which in turn improves with level up. It does not improve the armor...
Read more >American Rolls Out Free Elite Companion Upgrades
American AAdvantage has introduced complimentary companion upgrades for elite members, and is discontinuing 500-mile upgrades.
Read more >The Last of Us Part 1's Companion A.I Improvements Are a Big ...
Of the many improvements The Last of Us: Part 1 will bring to the original game, one of the most welcome features is...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Not that I know of. AFAIK Tus supports uploading streams with unknown length so it should be good.
I think this issue is different from #3180. #3180 is about small breaking changes we want to do in the next major. This issue is more about non-breaking changes which would improve companion, but I didn’t want to make an issue for each of the improvements, as we would end up with very many issues then. And I didn’t find any other place they fit in, so I put them here.
I’ll move the last point to #3268 👍