Metafields With XHRUpload `bundle` option

I needed the meta fields with the bundle option and I saw that it had not been implemented yet so I forked the code and tested it out. It’s fairly simple; I just copied and adapted code from createFormDataUpload. This goes right after the new FormData() in src/plugins/XHRUpload.js. I’m just getting into this code so I was wondering if anyone could take a look at it and see if it makes sense.

      const meta = this.uppy.getState().meta
      const metaFields = Array.isArray(this.opts.metaFields)
        ? this.opts.metaFields
        // Send along all fields by default.
        : Object.keys(meta)
      metaFields.forEach((item) => {
        formData.append(item, meta[item])
      })

[goto-bus-stop]

Previously we did not implement this because metadata in Uppy can be file specific. It was unclear what the expected behaviour would be when uploading multiple files with different metadata in one request. I think only sending global metadata probably makes sense…

[kvz]

Sorry for the long delay, we do want to implement ‘global meta data’, it’s just that we’ve been swamped! @goto-bus-stop has this high up on their list. Goes without saying but we’re also welcoming PRs if this is really important to your use case.