Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Adding lockfiles to examples

See original GitHub issue

examples/* doesn’t have lockfiles right now as they’re part of the monorepo
this might make the vercel deployment randomly fail if someone publishes a bad build of the 10^100 sub-deps of next (as shown yesterday in https://github.com/trpc/trpc/pull/91#issuecomment-781434382)
would be nice if they had lockfiles but not sure how to make it happen in the yarn workspace

Issue Analytics

State:
Created 3 years ago
Comments:9 (7 by maintainers)

Top GitHub Comments

1reaction

KATTcommented, Nov 27, 2022

Feel free to work at this. Seems like @QuiiBz has a good idea how to solve it, we can try that

1reaction

sachinrajacommented, Feb 22, 2022

Not sure if it’s also a problem here, but I’ve had issues with trying to detach the examples when using react in my monorepos. Since the @trpc packages depend on React as a dev dependency, it is installed in node_modules and webpack may resolve react from there. But it is also installed as a peer dependency and webpack also bundles that. Since you can’t have two versions of react, that will break it. Related issue I made for pnpm: https://github.com/pnpm/pnpm/discussions/3833. Also yarn won’t be able to link the example packages to the actual @trpc packages in the monorepo automatically. We’ll have to use a special specifier like file:. If the examples are workspaces, then yarn can dedupe react by hoisting it to a shared node_modules so webpack only resolves one instance of it.