Result.ok() gone in 5.x

We’re upgrading from 4.1.1 to 5.1.0 and one large change we needed to do in our codebase was to replace Result.ok() with Result.ok(Unit) or else we were getting:

Error: Tried to construct `Ok` with `null`. Maybe you want `Maybe.Nothing`?

Two things I’d like to ask:

1. Why is this a runtime check instead of a compile time check? The .d.ts files contain export declare function ok<T, E>(): Result<Unit, E>; so all our code typechecked, but it blows up in runtime. If this is not a function call users of the library should not make then I think ideally it shouldn’t typecheck.
2. Can we get this convenience method back? One of the nice things about true-myth is that Result, Maybe, and Unit types are nicely connected to each other and this was one of the nicenesses. On using Maybe instead of Result: I think Maybe<ErrorType> is not as clear as Result<Unit, ErrorType> in terms of what the code is doing.

Thanks!

[krivachy]

Thanks for the speedy fix @chriskrycho! We love to use true-myth 🔮 in our codebase ❤️

[chriskrycho]

Fix released in v5.1.1. Thanks again for the report!