Import fails on MacOS with Node 12

I’m unable to use ganache-core on MacOS with Node 12. I seem to have hit a combination of #297 (optional depencency on scrypt is not so optional) and https://github.com/barrysteyn/node-scrypt/issues/192 (scrypt doesn’t and will never work on MacOS and Node 12).

Expected Behavior

When I import ganache-core, I expect no errors.

Current Behavior

I see the following error:

Error: Cannot find module 'scrypt'
Require stack:
- /Users/mark/Development/ganache-core/node_modules/web3-eth-accounts/node_modules/scrypt.js/node.js
- /Users/mark/Development/ganache-core/node_modules/web3-eth-accounts/src/index.js
- /Users/mark/Development/ganache-core/node_modules/web3-eth/src/index.js
- /Users/mark/Development/ganache-core/build/ganache.core.node.js
- /Users/mark/Development/ganache-core/index.js
etc..

Possible Solution

Updating ethereumjs-wallet and web3 to the latest versions should remove the dependency on scrypt.

Steps to Reproduce (for bugs)

Luckily the problem also manifests itself when running the unit tests of ganache-core, so the steps to reproduce are simple:

1. Checkout ganache-core on a Mac with Node 12
2. yarn
3. yarn build
4. yarn test

Context

I use ganache-core as a web3 provider in Truffle for testing.

Your Environment

• Version used: latest develop (cba166610008262266a60908d7ab4eb20fd856be)
• Environment name and version: Node 12.1.0
• Operating System and version: MacOS Mojave
• Link to your project: https://github.com/sustainablesource/sustainablesource

[davidmurdoch]

Thanks for this! These abandoned native transitive deps have been quite the headache for many projects here at Truffle!

[markspanbroek]

Thanks! Works like a charm.