Truffle - test: Cannot create property 'negative' on number '1'

Issue

There seems to be some terrible bugs on the current big number implementation, and it’s breaking tests.

Steps to Reproduce

My case was during a test, but i can also do it using truffle develop with a simpler case:

>  n = new web3.utils.BN('1'); n.sub('1')

/workspace/node_modules/truffle/build/cli.bundled.js:1315
      num.negative = 0;
                   ^

TypeError: Cannot create property 'negative' on string '1'

Seems to be some crazy internal error. Possible reference

Expected Behavior

Not an internal error

Environment

• Operating System: MacOS
• Ethereum client: ?
• Truffle version (truffle version): 5.0.12
• node version (node --version): v11.4.0
• npm version (npm --version):

[flockonus]

Thanks @eggplantzzz , the workaround I’m using currently is to cast the string also into BN. Example:

n = new web3.utils.BN('1'); n.sub(web3.utils.toBN('1'))

[eggplantzzz]

@flockonus Thanks for the heads up! We’ll keep this in mind and follow the BN issue that you linked above.