Check nginx install without dpkg

Summary

Regarding https://github.com/TryGhost/Ghost-CLI/blob/master/extensions/nginx/index.js#L282

    isSupported() {
        try {
            execa.shellSync('dpkg -l | grep nginx', {stdio: 'ignore'});
            return true;
        } catch (e) {
            return false;
        }
    }

We check Nginx by using a third-party command called dpkg that is available only on Debian-based distributions. I use Arch linux and I have nginx installed. I can check it with

    isSupported() {
        try {
            execa.shellSync('nginx -v', {stdio: 'ignore'});
            return true;
        } catch (e) {
            return false;
        }
    }

Then the command ghost setup nginx can do everything it needs:

/v/w/ghost> ghost setup nginx
✔ Creating nginx config file at /var/www/ghost/system/files/servername.conf
+ sudo ln -sf /var/www/ghost/system/files/servername.conf /etc/nginx/sites-available/servername.conf
+ sudo ln -sf /etc/nginx/sites-available/servername.conf /etc/nginx/sites-enabled/servername.conf
+ sudo nginx -s reload
✔ Setting up Nginx

Can we not consider using nginx -v to check for the presence of nginx?

[enguerran]

Thank you very much @acburdine for following up on this modification request which is clearly not proprietary but which I am very pleased with!

[acburdine]

@enguerran I’ve refactored the stack check to use systeminformation’s services utility to check if nginx is installed by iterating over the list of installed services, rather than distro-specific command like dpkg.

This change will be released with Ghost-CLI 1.15.0.