`ghost install` doesn't run system checks early enough / `ghost doctor` is incomplete
See original GitHub issueThe move towards extensions has broken from the original intention of the cli single ghost install
command & ghost doctor
commands. In terms of doing full stack checks up front.
When I run ghost doctor
I expect it to perform all system checks, and tell me whether it’s safe to run ghost install
& perhaps even early indicate I should use ghost install local
. It currently only checks the node version and folder permissions.
If ghost doctor
says everything is A-OK, that should be a sign that ghost install
will complete using the standard recommended flow (e.g. including mysql, nginx, etc).
When I run ghost install
, I expect ghost doctor
to happen first, running all the checks and giving me the option to proceed if at all possible.
Here’s what happens if you try to install Ghost on a mac:
Note: everything starts of green and shiny and then gets yellower and scarier and suddenly we’re talking about nginx.
My expectation would be that this message:
System Stack checks failed with message: 'Platform is not Linux'.
Some features of Ghost-CLI may not work without additional configuration.\
? Continue anyways? Yes
Would appear before ghost-cli attempted to do a download and install, and then got stuck into trying to do stuff with MySQL.
The reason is, people don’t know how to use ghost-cli yet. It’s a brand new tool, I anticipate many people installing it on their mac or windows box to try it out and getting started with ghost install
, not realising that ghost install local
is for them.
The ideal situation would be that this message would appear before the download, install and prompts, with an additional indicator to use ghost install local
:
System Stack checks failed with message: 'Platform is not Linux'.
Some features of Ghost-CLI may not work without additional configuration.
For local installs we recommend using `ghost install local` instead.
? Continue anyways? Yes
I realise this will take a bit of a rejig, and prob needs to happen post 1.0 now, however I do believe we need to work toward this.
Issue Analytics
- State:
- Created 6 years ago
- Comments:8 (8 by maintainers)
No we should still do the checks.
--no-stack
skips the stack checks, I believe?Yes, definitely an edge case. Everyone has to run
ghost install
of some description, not everyone has to runghost setup
. If someone intentionally skips the stack checks during install we can assume they know what they are doing. If they then get themselves into trouble, that’s their own problem.If it turns out this is common, we can look at it again, but to me the most logical answer is, if a stack-related thing throws an error in
ghost setup
, it can spit out a message telling people to runghost doctor
.