Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Editor: Resolve more oembed URLs (e.g. Facebook posts)

See original GitHub issue

There are some embed links which are not supported yet e.g. Facebook posts.

Note: Facebook post embeds were enabled in https://github.com/TryGhost/Ghost/pull/9803, we still want to enable the <link rel="alternate"> lookup mentioned below to support other providers that may not be listed on https://oembed.com

Steps to reproduce

Open the Koenig Editor
Click on the card menu “+”
Select Facebook embed
Paste a link to a public Facebook post
See that it errors

Plan

There’s a two prong approach to this issue:

Add missing oembed providers to the oembed.com providers list then update the oembed-parser library that Ghost uses
Update our oembed endpoint to fetch the URL and look for a <link rel="alternate" type="application/json+oembed" href="..."> tag when no local lookup is possible

Issue Analytics

State:
Created 5 years ago
Comments:11 (11 by maintainers)

Top GitHub Comments

1reaction

kevinansfieldcommented, Aug 25, 2018

@lunaticmonk that’s a different issue 😃 we already have designs for that. This issue is about loading oembed data for providers that we don’t have explicit oembed endpoints for

1reaction

kevinansfieldcommented, Aug 16, 2018

@lunaticmonk the opengraph work is already planned. What could be useful is a PR to https://github.com/iamcal/oembed that adds a Facebook (Post) provider