Koenig: Final Ghost 2.0 Version

This issue captures the tasks that we’ll be working on for the fourth 6-week Koenig sprint. All work will take place on master and will be available in the weekly releases behind a labs flag for anyone wanting to help test. The plan is to replace Ghost’s current editor with Koenig at the end of the cycle.

part of TryGhost/Ghost#9311 (Feature: Full Koenig editor)

I want to help test! How do I get started?

See the instructions here.

---

🏃 in-progress 🚢 ready for next release (typically every Tuesday)

Release blockers

• ✨ supported sources popup / help page for embed card
• ✨ unsupported browser / mobile editing communication
  • basic implementation in https://github.com/TryGhost/Ghost-Admin/commit/b2a9e4cdd5fb4042d47489b1b0cb691bcb63f3cb

Released:

• ✨ word count / reading time display
• ✨ full text-editing keyboard shortcuts implementation
• 🎨 <kbd>Cmd+Enter</kbd> should exit card edit mode as well as enter it
• 🐛 Support schema-less URLs in embed cards
• 🐛 Firefox <kbd>Up/Down</kbd> arrow keys jump to top/bottom of doc when hitting a section boundary
  • this is caused by display: flex on the contenteditable element and appears to be a Firefox bug
  • removing display: flex breaks larger image widths
• 🐛 Slash-menu doesn’t work after clicking “New story” whilst in the editor
• 🐛 Clicking Embed cards from the /-menu throws errors
• 🐛 Clicking the “Retry” link in the embed card error message doesn’t return to URL input
• 🐛 Clicking Markdown/HTML/embed cards from the /-menu doesn’t create the card
• 🐛 Firefox triple-click to select then typing doesn’t replace content (mobiledoc-kit issue, PR)
• 🐛 <kbd>Option + Backspace</kbd> delete only until the first letter with accent (mobiledoc-kit issue, PR)
• 🐛 Safari scrolls to the bottom when interacting with the link toolbar
• 🐛 Double-clicks on the MD card whilst it’s selected can unexpectedly trigger toolbar buttons when transitioning to edit mode
• 🐛 Clicking the (+) button when the cursor is not in the respective blank paragraph moves the cursor rather than opening the menu. Requires a second click to open
• 🐛 Firefox <kbd>Up</kbd> requires two presses to move up from a divider card and gets stuck on image cards
• 🐛 Safari doesn’t display “wide” images correctly at all window sizes
• 🐛 Dropping an image on the editor before a cursor has been placed throws an error
• 🐛 Dropping an image on an image card creates two image cards
• 🐛 Cutting a selection that includes a list item and a card loses the card when pasting (mobiledoc-kit issue, PR)

Stretch goals

• ✨ hide sidebar on editor screen
• ✨ support /image https://example.com/image.jpeg slash menu shortcut
• ✨ create an embed card when pasting a URL in a blank section if it matches a known provider
• ✨ rich-text captions
• ✨ 🚢 Unsplash image selection for image card
• ✨ 🚢 general docs and help popup / link
• ✨ create an embed card based on opengraph data if there’s no direct oembed provider
• ✨ warn if leaving whilst an upload is in progress
• 🐛 emoji’s do not play nicely with the cursor. With 🤷🏻‍♂️ for example you need to press <kbd>Left</kbd> 6 times to move the cursor from one side to the other and <kbd>Backspace</kbd> will cycle through various forms of the emoji until it’s finally deleted and doesn’t always play nicely with the undo stack
  • Dropbox Paper converts all emoji’s into an “atom” type element
  • Medium has similar struggles except it also doesn’t render correctly
  • mobiledoc-kit issue

[kevinansfield]

2.0 has been cut, any outstanding Koenig bugs or features will be opened as separate issues.

The embed card loading bug referenced in the comments above has been opened https://github.com/TryGhost/Ghost/issues/9796

[JohnONolan]

Can consistently reproduce this (pasting https://www.instagram.com/p/Bjo_mgTjOH-/?taken-by=johnonolan ) onto first line

• Can’t reliably reproduce the case above where all stopped working.
• Can semi-reliabilty repeat twitter styles not loading
• Instagram styles always break during insertion