Many small tooling cleanup tasks

This issue contains a list of mostly small cleanup tasks for our tooling.

Aim is to move towards consistency between repos (both public and private) to lean on package.json scripts more heavily where possible, simplify grunt & essentially make this repo neater & easier to use 😁

• Switch eslint to use eslint-plugin-ghost (OK this isn’t that small)
• Use .js files rather than .json for eslint config
• Remove grunt-eslint, use grunt run or grunt shell instead cos it’s more generic, and we can do other things this way
• Add lint as a script in package.json
• Swap .gitignore for standardised file + customisations at end
• Fix .gitignore so we don’t have tracked files in in the ignore:

content/data/README.md
content/themes/casper/
content/apps/README.md
content/images/README.md
content/logs/README.md
core/server/public/ghost-sdk.min.js
core/server/web/admin/views/.gitkeep

• Review .npmignore file
• grunt release creates a zip with contents which do not equal .tgz (e.g. https://github.com/TryGhost/Ghost/commit/0db01a02374bfddcca08fb9ecd2286d078f9a74c)
• Refactor Gruntfile.js so it isn’t so indented
• We aren’t using greenkeeper - cleanup ignores from package.json
• Why is minimist a dev dep?!
• Fix brute-knex dependency
• Consider moving coverage out of grunt into a script in package.json
• Consider tests: can we restructure them so they are easier to run? 🤔
• Let grunt master fail when working tree is not clean

[allouis]

The output tars/zipz of grunt release and npm pack now unpack to the same directories, apart from these two files:

>> diff -r tgz/ zip/
Only in zip/core/server/lib/members/static/auth: dist
Only in zip/core/server/lib/members/static/auth: index.html

This will be fixed when members has been moved into it’s own monorepo.which is tracked here: https://github.com/TryGhost/Ghost/issues/10701

Closing this now 🎉

[allouis]

grunt release creates a zip with contents which do not equal .tgz

After creating a release zip and using npm pack to create a tarball, I extracted them to a zip and tgz directory respectively.

 >> diff -r tgz/ zip/
Only in tgz/content/themes/casper/assets/css: .csscomb.json
Only in zip/content/themes/casper: config.example.json
Only in tgz/content/themes/casper: .yarnrc
Only in zip/core/server/lib/members/static/auth: dist
Only in zip/core/server/lib/members/static/auth: index.html
Only in zip/core/server/lib/members/static/gateway: index.html
Only in tgz/core/server/web/admin/views: .gitkeep
Only in tgz/: .eslintignore
Only in tgz/: .eslintrc.json
Only in tgz/: .npmignore

Will work on resolving these differences