[BUG] Probleme with OnDeserialize when multiple array

Information

• Version: 6.59.2
• Packages:

    "@tsed/ajv": "6.59.2",
    "@tsed/common": "6.59.2",
    "@tsed/core": "6.59.2",
    "@tsed/di": "6.59.2",
    "@tsed/exceptions": "6.59.2",
    "@tsed/json-mapper": "6.59.2",
    "@tsed/platform-express": "6.59.2",
    "@tsed/schema": "6.59.2",
    "@tsed/swagger": "6.59.2",
    "@tsed/typeorm": "6.43.0",

The object I want to deserialize contain 2 attributes which array array of typed object. But in the OnDeserialize I get the 2 array mixed.

Example

// in foo.ts
import { OnDeserialize } from '@tsed/json-mapper';

export class Foo {
  @CollectionOf(String)
  @OnDeserialize(features => {
    console.log('features:', features);
    return features;
  })
  features: string[];
  @CollectionOf(String)
  @OnDeserialize(filters => {
    console.log('filters:', filters); 
    return filters;
  })
  filters: string[];
}

// In bar.controller.ts
@Controller('/bar')
@MergeParams()
export class BarController {
  @Post('')
  async createFoo(
    @Required() @BodyParams() foo: Foo
  ): Foo {
    return foo; 
  }

When I do POST - http://localhost:3000/foo with this body :

{
	"features": ["feature1", "feature2"],
	"filters": ["filter1", "filter2"]
}

Here is my console output:

features: [ 'feature1', 'feature2', 'filter1', 'filter2' ]
filters: [ 'feature1', 'feature2', 'filter1', 'filter2' ]
features: [ 'feature1', 'feature2', 'filter1', 'filter2' ]
filters: [ 'feature1', 'feature2', 'filter1', 'filter2' ]

Acceptance criteria

• OnDeserialize should get only the data associated with the named property
• OnDeserialize should be call only one time by property

[TakeshiDaveau]

Hello @Romakita

Thanks for your answer, I’ll check this, maybe something specific we’ve added to our project create this bug.

I’ll let you know when I have more information.

Bye Takeshi

[Romakita]

Hello @TakeshiDaveau I’ll try to fix this issue tomorrow 😉

see you Romain