question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Extra arguments to map_ancestors to control behaviour of marginal cases

See original GitHub issue

The current implementation of map_ancestors has the following behaviour for combinations of nodes from samples and ancestors:

Type of relationship Shown in output of map_ancestors
ancestor->sample Always
ancestor1->ancestor2 Only if ancestor2 has a relevant descendant
sample1->sample2 Always
sample->ancestor Only if ancestor has a relevant descendant

(I designed the algorithm with a situation in mind in which only the first row is relevant: where all samples are taken from a single time point, and all ancestors are taken from an earlier single time point.)

However, it shouldn’t be too difficult to specify different behaviours under these other cases with extra inputs to map_ancestors - I’m happy to look into this later on if this seems useful.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
petrelharpcommented, Jul 22, 2019

From https://github.com/tskit-dev/tskit/issues/262

Nope, the function will fail if it is passed no ancestors. If you want to find relationships between all samples, you should just pass samples and ancestors the same list of nodes.

Oh! Let’s add this note to the documentation! This is very useful.

0reactions
petrelharpcommented, Jul 22, 2019

This table is extremely helpful; good idea. I’m not sure it’s correct, though? I will comment in the code.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Argument from marginal cases - Wikipedia
The argument from marginal cases is a philosophical argument within animal rights theory regarding the moral status of non-human animals.
Read more >
Objections to the Marginal Case Argument
Scientists are often challenged with the so-called marginal case argument. We are asked to spell out the criteria that make our experiments ...
Read more >
Alastair Norcross Puppies, Pigs, and People: Eating Meat and ...
The argument from marginal cases claims that. a. some animals have rational capacities to the degree that some humans do. b. animals have...
Read more >
PUPPIES, PIGS, AND PEOPLE: EATING MEAT AND ...
I will consider two lines of response to the argument from marginal cases. The first denies that we have to attribute different moral...
Read more >
Animals and Ethics | Internet Encyclopedia of Philosophy
The Argument From Marginal Cases; Problems with Indirect Duties to Animals ... More recently, arguments against animal consciousness have been resurfacing.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found