TableCollection.sort and simplify no longer release GIL

When changing the sort_tables and simplify_tables functions to be methods of the TableCollection object, I removed the complexity around dropping the GIL. This can be reinstated easily enough, but there are quite subtle issues around it so I didn’t want to do it in a hurry.

Is this still important to you @molpopgen?

[molpopgen]

@jeromekelleher – we can close this (ancient) one.

[molpopgen]

No–having the tskit API eventually separated out will allow one to do this on one’s own.

On Fri, Jan 11, 2019 at 9:11 AM Jerome Kelleher [e-mail] wrote:

When changing the sort_tables and simplify_tables functions to be methods of the TableCollection object, I removed the complexity around dropping the GIL. This can be reinstated easily enough, but there are quite subtle issues around it so I didn’t want to do it in a hurry.

Is this still important to you @molpopgen https://github.com/molpopgen?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tskit-dev/tskit/issues/70, or mute the thread https://github.com/notifications/unsubscribe-auth/AGHnH4EuqkrOoR1r2u4if_Wyfn4PXPYtks5vCMWIgaJpZM4Z72RQ .

On Fri, Jan 11, 2019 at 9:11 AM Jerome Kelleher [e-mail] wrote:

When changing the sort_tables and simplify_tables functions to be methods of the TableCollection object, I removed the complexity around dropping the GIL. This can be reinstated easily enough, but there are quite subtle issues around it so I didn’t want to do it in a hurry.

Is this still important to you @molpopgen https://github.com/molpopgen?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tskit-dev/tskit/issues/70, or mute the thread https://github.com/notifications/unsubscribe-auth/AGHnH4EuqkrOoR1r2u4if_Wyfn4PXPYtks5vCMWIgaJpZM4Z72RQ .