question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Inline with the suggestions contained within #1428 I’ve been working on getting a v7 release ready (see #1432)

API Changes

  • There haven’t been any changes to module API’s

Higher level changes

  • Modules are now ES6 modules, written in plain ol’ js, and built into a single package using rollup
  • Lerna is now no longer used for publishing as only a single package is published

Module enhancements

  • JSTS has been replaced in union, difference, intersect by polygon-clipping -dissolve has been overhauled
  • a number of other minor enhancements and fixes to modules…

Testing

  • My initial testing of the alpha bundle has been going ok
  • @shongololo has raised an issue around ReferenceError: m is not defined when buffering linestrings.
    • need to do a bit of digging here, may be a minification issue or something else… although see note below, ideally I’m hoping to do away with the jsts dependency in the buffer module

Outstanding issues

  • The only module where jsts remains in use is buffer. I’m currently working on a replacement here
  • In the buffer replacement above I’m trying to build my library pulling in a couple of turf modules (eg coordEach). For some reason the build is pulling in all of turf rather than just the couple of modules I want (aka tree-shaking doesn’t appear to be working…)
    • In my case I’m again using rollup as my build tool. I could perhaps investigate using webpack although it would be nice to have turf ‘just working’ irrespective of build tool choice.

Where to find it

What next

  • Try to resolve tree-shaking issue noted above
  • Publicise changes more widely

cc @stebogit @tmcw

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:4
  • Comments:15 (4 by maintainers)

github_iconTop GitHub Comments

2reactions
rowanwinscommented, May 28, 2019

Hi @zakjan & @dpmcmlxxvi

There are a few more unresolved issues around the polygon-clipping library that are preventing it from shaking properly, for example I think this use of the singleton pattern, as well as these variables and functions. I have a version locally which shakes however it breaks a lot of tests which would need to be refactored accordingly.

With tree-shaking I think the meta and helper modules these will be relatively low priority as minified they come out very small.

I’ve also released point-in-polygon-hao recently which works with polygons containing holes out of the box as well as degenerate polygons (compared to point-in-polygon).

2reactions
sheeruncommented, Apr 17, 2019

Our application size is suffering from jsts. Maybe some help rewriting buffer? Could you point to something?

Read more comments on GitHub >

github_iconTop Results From Across the Web

A new alpha! v7.0.0-alpha2 - OpenFlexure Forum
We just released the second alpha release of v7 of the microscope The instructions for the High resolution version should be significantly improved....
Read more >
Squad - Alpha V7 Release! - Steam News
There is a known camera bug when exiting vehicles including stationary .50 cals in the Firing Range. Simply enter the admin cam (Shift...
Read more >
v7.3.77 Alpha Release. + Added in launch feedback ... - Medium
This release is due based on the feedback we have been given from our Alpha Users. The feedback has been incredibly valuable to...
Read more >
Corona Alpha7 is out!
Corona Renderer V7. Exactly 3 months and 13 days after releasing Alpha V6 we are back with the fresh new version 7.
Read more >
Sequelize v7 (alpha)
Version 7 of Sequelize officially supports the Node.js versions ^14.17,0 , ^16.0.0 . Other version might be working as well. You are currently ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found