CORS Enable Headers

Hi, my implementation was failing due to missing headers in response. File uploads were not resuming. I inspected the http://tus.io/demo.html network requests and noticed this header, which was missing in my node server’s responses:

'Access-Control-Expose-Headers' : 'Upload-Offset, Location, Upload-Length, Tus-Version, Tus-Resumable, Tus-Max-Size, Tus-Extension, Upload-Metadata'

I examined the node.js library code a little bit, and discovered that on Server.js file you are controlling CORS with the following lines :

if (req.headers.origin) {
     res.setHeader('Access-Control-Allow-Origin', req.headers.origin);
}

I believe it should also set the “Access-Control-Expose-Headers” header too. So i changed to following piece of code and it worked :

if (req.headers.origin) {
     res.setHeader('Access-Control-Allow-Origin', req.headers.origin);
     res.setHeader('Access-Control-Expose-Headers' , 'Upload-Offset, Location, Upload-Length, Tus-Version, Tus-Resumable, Tus-Max-Size, Tus-Extension, Upload-Metadata');
}

Is there a better way to achieve CORS, or is this the way to do it? Thank you.

[krampampuli]

Since there was no Location info, the URL for PATCH was null. That was the actual error. Now everything seems to be OK, thank you!

[bhstahl]

@krampampuli thanks for your help. Location is added in tus-node-server@0.1.3.

Not sure I’m following how PATCH isn’t allowed, since it is included in the Access-Control-Allow-Methods of OPTIONS request. Would you mind opening up a separate ticket with detailed steps to replicate?